From: Jasper St. Pierre Date: Sun, 17 Feb 2013 19:26:04 +0000 (-0500) Subject: messageTray: Don't allow opening while entering/leaving the overview X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~4772 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=ee62863759a212caccba5de29dcea5d90baeb7ff;p=gnome-shell.git messageTray: Don't allow opening while entering/leaving the overview The complex overview transition code means that there's no easy way to handle with this right now. Blocking the message tray while the overview is animating seems like the correct thing to do. https://bugzilla.gnome.org/show_bug.cgi?id=694038 --- diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index 16064ebde..eb63266b1 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -2031,18 +2031,25 @@ const MessageTray = new Lang.Class({ }, openTray: function() { + if (Main.overview.animationInProgress) + return; + this._traySummoned = true; this._updateState(); }, toggle: function() { + if (Main.overview.animationInProgress) + return false; + this._traySummoned = !this._traySummoned; this._updateState(); + return true; }, toggleAndNavigate: function() { - this.toggle(); - this._summary.navigate_focus(null, Gtk.DirectionType.TAB_FORWARD, false); + if (this.toggle()) + this._summary.navigate_focus(null, Gtk.DirectionType.TAB_FORWARD, false); }, hide: function() {